[DirectX] Adding support for static samplers in yaml2obj/obj2yaml #139963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 24, 2025 22:06
joaosaffran
changed the base branch from
users/joaosaffran/138318
to
users/joaosaffran/138315
joaosaffran
changed the base branch from
users/joaosaffran/138315
to
users/joaosaffran/138318
joaosaffran
changed the base branch from
users/joaosaffran/138318
to
users/joaosaffran/138315
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bogner
approved these changes
May 29, 2025
Contributor
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
LGTM other than one comment about consistently using the ASSERT_* vs EXPECT_* macros in the tests.
| ASSERT_EQ(Sampler.MaxAnisotropy, 20u); | ||
| ASSERT_EQ(Sampler.ComparisonFunc, 4u); | ||
| ASSERT_EQ(Sampler.BorderColor, 0u); | ||
| EXPECT_FLOAT_EQ(Sampler.MinLOD, 4.56); |
Contributor
There was a problem hiding this comment.
Shouldn't these be ASSERT_FLOAT_EQ? IIUC ASSERT_* stops immediately if the condition isn't met and EXPECT_* allow us to diagnose multiple issues. I don't think it makes sense to use one for the floating point fields and the other for the rest of the fields.
inbelic
approved these changes
May 29, 2025
Contributor
inbelic
left a comment
inbelic
left a comment
There was a problem hiding this comment.
LGTM. Did you want something to track and update going through all the previously defined parameters and marking them as optional yaml parameters if applicable?
inbelic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: 126636